Fix doc api #3791
Merged
Fix doc api #3791
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Michael-F-Bryan
suggested changes
Apr 20, 2023
There was a problem hiding this comment.
Instead of using make build-docs-api and trying to keep track of how docs.rs will build the wasmer crate, we can use the same tooling docs.rs uses for generating docs. That way we won't need to remember to keep feature flags in sync.
The wasmer-wasix crate has the same issue as wasmer v3.2.0 where docs won't build... Is it possible to make this CI job generate docs for all our crates?
Michael-F-Bryan
approved these changes
Apr 20, 2023
There was a problem hiding this comment.
After chatting with @ptitSeb, we're going to keep the make build-docs-api as-is and make the "proper" fix as part of our upcoming build system work.
Michael-F-Bryan
force-pushed
the
fix_doc_api
branch
from
ae07ccc to
c3ee3c1
Compare
theduke
approved these changes
Apr 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fix the building of the API Doc
It also add an option in the Makefile to build the API Doc
And a CI test too.
Address #3787